Thanks for the nice words.

Now regarding if, for, while, etc: I was initially using fit.decorator’s loop fixture for looping support but since fit.decorator didn’t have support of variables I had to modify it locally.

As a much better support of these constructs (if, for, while, etc) I have actually integrated bean shell interpreter via GenericFixture and DSLAdapter. I have yet to publish a Blog post on examples and how-to’.
But in summary:
1. Get bsh.jar and put it in FitNesse’s classpath, using !path directive.
2. Then use a DSL like this anywhere in your scripts:
!| DSL Adapter |
| check if array | % | has | % | GenericFixture.bsh | boolean has=false; if (java.util.Arrays.binarySearch({1}, "{2}") > 0) has=true; return has; |
| check if | % | is between | % | and | % | GenericFixture.bsh | return {1} > {2} && {1} <= {3}; |
3. And finally call this DSL script like:
| check if | someVar | is between | 4 | and | 7 | | true |
| check if array | arr | has | indeed | | true |

I know it wont's be very clear from this comment so please pardon me till I create a proper Blog post with full working examples and detailed instructions.

Cheers,
Anubhava

PS; However as a matter of practice I don’t recommend writing a complex test script with all kind ifs, whiles, dos etc. It makes it harder to maintain and less readable. I would rather create a helper class and do complex looping, branching, calculations inside that and then call helper class methods via Generic Fixture.

First of all I wanted to say thanks for putting this together. It makes jumping into Fitnesse testing much easier. I was curious if you had considered or implemented anything in the GenericFixture with regards to flow control (if, for, while, etc). One of the powers of Fitnesse is the ability to define a table of values that you can have Fitnesse churn through via a fixture. Just curious.

Thanks,
Michael

There are couple of syntax errors in your DSL. As you are aware now that comma characters inside parameters need to be escaped out in DSL. Additionally you have used assignment(=) instead of comparison(==) in the 2nd condition of your Javascript.

Let me give you the syntax corrected definition:

!| DSL Adapter |
| wait for element with id | % | to not be visible | waitForCondition | window.document.evaluate( "count(//node()[@id='{1}'])"\, document\, null\, XPathResult.NUMBER_TYPE\, null ).numberValue == 0 !-||-! window.document.getElementById('{1}').scrollWidth == 1, 120000 |

Please try it and see if it resolves your error.

If not I would suggest to include this code in a small JUnit test case and call your Selenium server from there since you are getting this exception from Selenium API. Once working in JUnit code you can always translate it back to Generic Fixture’s DSL.

Cheers,
Anubhava

Thank you for your constant support.
Regarding the last issue I had mentioned, the escaping of the comma seems to work ok, but now we get another error that we can not resolve and I’d like to ask for your help.

The dsl is:
!| DSL Adapter |
| wait for element with id | % | to not be visible | waitForCondition | window.document.evaluate( “count(//node()[@id='{1}'])”, document, null, XPathResult.NUMBER_TYPE, null ).numberValue == 0 !-||-! window.document.getElementById(’{1}’).scrollWidth =1, 120000 |

And the error returned is the following:

com.thoughtworks.selenium.SeleniumException: Node cannot be used in a document other than the one in which it was created

We also tried using instead of window.document.
this:
selenium.browserbot.getCurrentWindow().document.
and this:
document.importNode(window.document\,true).

but none works.

any help would be greatly appreciated.

Thanks in advance.

Thanks a lot for your help.

Cheers,
Sérgio

Thanks for writing back to me.

Actually the problem was not the getParameters returning a list it was in fact the dilemma of resolving the variables either at “DSL to Java translation” stage or at execution stage. As you notice that a variable can store any object not just String or String compatible objects therefore I have decided to leave variable resolution at the late stage i.e. execution stage.

New genericfixture.jar has been uploaded to the sourceforge repository. Please download the latest jar file for your test. It should fix the problem for you.

cheers,
Anubhava

The getParameters method in the DSL Adapter class has a return type of List.
This disallows the use of non String objects in the DSL such as the example I’ve mentioned in a previous reply.

What happens now is that the ship object that is returned from:

| create ship with imoNumber | % | and name | % | setUp | shipFieldSetMapper , array:{1}\,{2}\,”\,” , array:ImoNumber\,Name\,NameEffectDate\,MmsiNumber |

when invoking the following example is being converted to a String and causing a an error inside the method

!| Generic Fixture | foodb= |
| delete ship | ship= |

Is this the expected behavior?

Thanks a lot for your help,
Sérgio

I found the issue and fixed it. Thanks a lot for bringing it up. New genericfixture.jar has been uploaded to the sourceforge repository. Please download the latest jar file for your test. It should fix the problem for you because I was able to reproduce the problem and then test it again after the fix.

Let me know how it goes.

Cheers,
Anubhava

After taking a look at your code I’ve noticed that the error was in following lines:

Object v = GenericFixture.fetchVariable( str );
if ( v != null && !v.getClass().isArray() )
str = (String) v;

Hence my question regarding the expected types for the variables.

Are we doing something wrong?

Thanks in advance,
Sérgio

I’m glad that you were able to resolve the previous issue.

No DSLAdapter doesn’t assume a variable to be String or Array or of any other type. Your script is like this:

!| Generic Fixture | foodb= |
| delete ship | ship= |

Which is basically calling a method defined by DSL “delete ship” on the object stored by a variable foodb= and you are supplying a variable ship= to your DSL.

Are your variables foodb= and ship= storing the values of the correct type?

To debug further can you check it by creating a variable foodClass= by calling getClass() and then getCanonicalName() method on it. something like this:

!| Generic Fixture | foodb= |
| foodClass=getClass |
| foodClass=.getCanonicalName | |
| shipClass=ship=.getClass |
| shipClass=.getCanonicalName | |
| delete ship | ship= |

Make sure above script prints correct object types in both calls of getCanonicalName methods.

Let me know how it goes.

Cheers,
Anubhava